commit ce01a84743a65ab222886b5fd0c1cf39d6bbee64 Author: Katrin Fischer Date: Mon Oct 28 12:58:37 2024 +0000 Bug 35659: (QA follow-up) Fix table heading and ID * ID is an abbreviation and spelled as such * We don't add administration to the h1 level, so made this consistent Signed-off-by: Katrin Fischer commit 25f9762b2981e15473ed674f6733e41914fe2181 Author: Katrin Fischer Date: Fri Oct 25 15:09:16 2024 +0000 Bug 35659: DBRev 24.06.00.47 Signed-off-by: Katrin Fischer commit 89faba23954f911cccae73440ac835c3b9277808 Author: David Cook Date: Tue Oct 22 01:34:04 2024 +0000 Bug 35659: (QA follow-up) Fix capitalisation in notice Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Katrin Fischer commit 1f5d8f0aef546ce5e09148b85f0b0e8964839d0a Author: David Cook Date: Tue Oct 22 01:26:02 2024 +0000 Bug 35659: (QA follow-up) Update syspref description to be a sentence Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Katrin Fischer commit 4e6386d2112fa6480cbd0c0ec86d0d00cf3c1cf6 Author: David Cook Date: Thu Sep 26 20:24:33 2024 +0000 Bug 35659: (follow-up) fix auth oai to MARC21 Signed-off-by: Victor Grousset/tuxayo Signed-off-by: David Cook Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Katrin Fischer commit 6512fe5c2ad0f0efd65fb6f4f2c6e650009b19cf Author: Andreas Roussos Date: Wed Sep 18 14:18:23 2024 +0000 Bug 35659: (follow-up) Adjust TT code for Bootstrap 5 In Bug 35402 the Bootstrap CSS framework was upgraded to version 5. This patch adjusts the relevant TT code for the OAI repositories administration page, and also adds a missing [% USE %] directive. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: David Cook Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Katrin Fischer commit 614392c6f0393554862378ecf4295448815d4e97 Author: Andreas Roussos Date: Wed Sep 18 14:01:21 2024 +0000 Bug 35659: (follow-up) Use new column name in cron script In an earlier patch, the `id` column of the `oai_servers` table was renamed to `oai_server_id`. However, the code in misc/cronjobs/harvest_oai.pl still uses the old column name, which results in the following error: $ misc/cronjobs/harvest_oai.pl --list DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'id' in 'order clause' at /kohadevbox/koha/Koha/Objects.pm line 403 This patch fixes that. Test plan: 1) $ misc/cronjobs/harvest_oai.pl --list [...you get the DBI Exception...] 2) Apply the patch. 3) $ misc/cronjobs/harvest_oai.pl --list [...list of OAI repositories...] Signed-off-by: Victor Grousset/tuxayo Signed-off-by: David Cook Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Katrin Fischer commit b2b54b835408e79ae4571c2949fcba89dd017f0b Author: Matthias Meusburger Date: Tue Sep 10 15:34:07 2024 +0000 Bug 35659: (QA follow-up): Add init function tests by using Koha's OAI server Signed-off-by: Victor Grousset/tuxayo Signed-off-by: David Cook Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Katrin Fischer commit 7134bca955be6d23cacc861eb38e58583a7de72a Author: Matthias Meusburger Date: Tue Sep 10 15:47:13 2024 +0000 Bug 35659: (QA follow-up): Add koha_object(s)_class functions for OaiServer.pm Signed-off-by: Victor Grousset/tuxayo Signed-off-by: David Cook Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Katrin Fischer commit 7cbb6eac2977b66c9f8141d12cbef527a250a2ca Author: Matthias Meusburger Date: Wed Jul 31 14:45:40 2024 +0000 Bug 35659: DBIC schema update Signed-off-by: Victor Grousset/tuxayo Signed-off-by: David Cook Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Katrin Fischer commit 09d86888a74e0d10094b07188f03d8bfa22701bb Author: Matthias Meusburger Date: Wed Jul 10 14:06:15 2024 +0000 Bug 35659: (QA follow-up): Auth unit tests & dbrev Add unit tests for authorities and deletion Fix dbrev and kohastructure discrepancies Signed-off-by: Victor Grousset/tuxayo Signed-off-by: David Cook Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Katrin Fischer commit d1b3ac503352cddbab31711e06ea12a1194197bf Author: Matthias Meusburger Date: Wed May 22 10:06:17 2024 +0000 Bug 35659: (more QA follow-ups) Rename Oaipmh to OAI Rename oaiservers to oai_servers Rename OaiServer to OAIServer Rename oai_servers.id to oai_servers.oai_server_id Rename ServerSearch to server_search Use a callback function for logs Use context for string "Set" Split translation string Signed-off-by: Victor Grousset/tuxayo Signed-off-by: David Cook Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Katrin Fischer commit c5fe62a65fddbeecbf249d1cfbd2ad121fb56b3a Author: Matthias Meusburger Date: Wed Apr 10 08:24:56 2024 +0000 Bug 35659: (QA follow-up) Signed-off-by: Julian Maurice Signed-off-by: Pedro Amorim Signed-off-by: Victor Grousset/tuxayo Signed-off-by: David Cook Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Katrin Fischer commit 1f27081f2ab28055ee460e7b58f279644186c139 Author: Matthias Meusburger Date: Wed Mar 20 10:32:51 2024 +0000 Bug 35659: (follow-up) Make OAI repositories edition comply with CSRF Signed-off-by: Julian Maurice Signed-off-by: Pedro Amorim Signed-off-by: Victor Grousset/tuxayo Signed-off-by: David Cook Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Katrin Fischer commit 389a7de850344844dd41a705de97905a9914148f Author: Andreas Roussos Date: Wed Feb 28 07:06:33 2024 +0000 Bug 35659: (follow-up) Better handling of accented characters If you try to harvest bibliographic records from a UNIMARC OAI repository (using oai_dc data format) in a MARC21 Koha instance and run the OAI harvester script in verbose mode, you may get lines similar to the following in the output: no mapping found for [0xC9] at position 0 in Économie politique g0=ASCII_DEFAULT g1=EXTENDED_LATIN at /usr/share/perl5/MARC/Charset.pm line 308. no mapping found for [0xC9] at position 0 in Église et société g0=ASCII_DEFAULT g1=EXTENDED_LATIN at /usr/share/perl5/MARC/Charset.pm line 308. When looking at the imported records' biblio details page in the OPAC, most words containing accented characters will not appear correctly. The fix is to apply Franck Theeten's solution from Bug 16488 (https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16488#c24) and modify the value of the MARC leader's 10th character to 'a' in the XSLT that transforms the UNIMARC OAI records into MARC21 XML. Then, the accented characters get imported properly and the records appear correctly in the OPAC. Test plan: 0) Without this patch, running the OAI harvesting script in verbose mode produces many warnings, and garbled characters appear in the OPAC biblio details page wherever accented characters are in use. 1) Apply this patch. 2) Re-run the OAI harvesting script in verbose + force mode (force mode is required to ignore record datestamps from previous runs): misc/cronjobs/harvest_oai.pl -v -r -f This time there should be no warnings printed on your screen, and any characters with accents in the updated records should look OK in the OPAC. Thanks-to: Franck Theeten Signed-off-by: Michal Denar Signed-off-by: Julian Maurice Signed-off-by: Pedro Amorim Signed-off-by: Victor Grousset/tuxayo Signed-off-by: David Cook Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Katrin Fischer commit d2367657b29bfb406303fd2c08396b528b20af1a Author: Matthias Meusburger Date: Thu Jul 20 16:29:49 2023 +0200 Bug 35659: OAI Harvester Test plan: - Run updatedatabase.pl - Apply the DBIC update patch - Setup an OAI repository in Administration -> OAI repositories (admin/oaiservers.pl) If the repository dataformat is in oai_dc, you can use the sample XSLT files: For Unimarc: OAIDCtoUNIMARCXML.xsl for bibliographic records AuthOAIDCtoUNIMARCXML.xsl for authorities For Marc21: OAIDCtoMARC21XML.xsl for bibliographic records AuthOAIDCtoMARC21XML.xsl for authorities If the repository dataformat is in marc-xml, you can use OAIMarcxml2KohaMarcxml.xsl for both Unimarc and Marc21. - Some repositories to test with: Bibliographic records, oai_dc: Endpoint: http://staroai.theses.fr/OAIHandler Set: ddc:260 XSLT: /koha-tmpl/intranet-tmpl/prog/en/xslt/OAIDCtoUNIMARCXML.xsl or XSLT: /koha-tmpl/intranet-tmpl/prog/en/xslt/OAIDCtoMARC21XML.xsl Authorities, oai_dc: Endpoint: https://www.idref.fr/OAI/oai.jsp Set: a XSLT: /koha-tmpl/intranet-tmpl/prog/en/xslt/AuthOAIDCtoUNIMARCXML.xsl or XSLT: /koha-tmpl/intranet-tmpl/prog/en/xslt/AuthOAIDCtoMARC21XML.xsl Authorities, marc-xml, Unimarc: Endpoint: https://www.idref.fr/OAI/oai.jsp Set: a XSLT: /koha-tmpl/intranet-tmpl/prog/en/xslt/OAIMarcxml2KohaMarcxml.xsl - Note: marc-xml harvesting will not work with HTTP::OAI::Harvester version 3.xx Version 4.xx is needed. See Bug 17704 for updating Koha default version to 4.xx - If you want to receive a report email, fill the OAI-PMH:HarvestEmailReport syspref. The model used (OAI_HARVEST_REPORT) can be edited in tools -> Notices and slips. - start a harvest with the following command: misc/cronjobs/harvest_oai.pl This script starts an OAI Harvest This script has the following parameters : -h --help: this message -v --verbose (enable output to stdout) -r --repository: id of the OAI repository -d --days: number of days to harvest from (optional) -l --list: list the OAI repositories -f --force: force harvesting (ignore records datestamps) (optional) Example: misc/cronjobs/harvest_oai.pl -r 1 -d 10 -v -f - Check the logs in the Log Viewer (tools/viewlog.pl) (CronjobLog syspref must be activated) Sponsored-by: KohaLa Signed-off-by: Michal Denar Signed-off-by: Julian Maurice Signed-off-by: Pedro Amorim Signed-off-by: Victor Grousset/tuxayo Signed-off-by: David Cook Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Katrin Fischer commit 474148538f8c52ae1438e8b606fcbb7577a76c9c Author: David Cook Date: Thu Oct 24 01:33:44 2024 +0000 Bug 14007: Filter search result values to remove OpacHiddenItems values This change filters the values from the OpacHiddenItems syspref out of their corresponding search results facets. Note: This does not mean that all values from hidden items are filtered out of facets. Rather, it just means that facet data that matches OpacHiddenItems is filtered out. This is an imperfect fix, but it is a practical fix that has been requested by more than one library. Test plan: 0. Apply the patch and koha-plack --restart kohadev 1. Go to http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=29 2. Add an item with an item type of "Maps" 3. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=OpacHiddenItems 4. Fill in OpacHiddenItems with the following: itype: ['MP'] 5. Go to http://localhost:8080/cgi-bin/koha/opac-search.pl?idx=&q=test&weight_search=1 6. Note that "Maps" does not appear in the "Item types" facet 7. Go to http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=test 8. Note that "Maps" does appear in the "Item types" facet 9. ***Repeat this test plan using both Elasticsearch and Zebra indexing*** 10. prove -v t/Koha/SearchEngine/Search.t Signed-off-by: David Nind Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer commit 738c641bccd7c65a7a3a22a5a898085a899b08cb Author: Jonathan Druart Date: Mon Oct 7 11:31:36 2024 +0200 Bug 38085: Pick multiple_sortable options for translation Bug 29948 added a "multiple_sortable" type for sysprefs, to have the options sortable. But the options were not picked for translation. This patch fixes it. Test plan: Run `cd misc/translator && perl translate update LANG` before and after this patch. Notice that with this patch you see the different options of OPACAuthorIdentifiersAndInformation in the LANG-pref.po file (eg. "Associated group (373$a$s$t$u$v$0)") Translate the options Install the translated version of the templates and confirm that the strings appear translated on the interface. Signed-off-by: Caroline Cyr La Rose Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer commit 884cd85201fdc90dfd26c69f1d3808e20f580184 Author: Katrin Fischer Date: Fri Oct 25 14:30:12 2024 +0000 Bug 38222: (QA follow-up) Fix translation and capitalization issues Signed-off-by: Katrin Fischer commit 193f9280282246e856daa3154fd4aa4a697398ad Author: Katrin Fischer Date: Fri Oct 25 14:29:10 2024 +0000 Bug 38222: DBRev 24.06.00.046 Signed-off-by: Katrin Fischer commit 54ac797887b7d201992f4c42528c75f1eeeafc93 Author: Paul Derscheid Date: Fri Oct 25 10:09:11 2024 +0000 Bug 38222: (QA follow-up) Limit combobox input in cancel booking modal to db field length Sponsored-by: Büchereizentrale Schleswig-Holstein Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit c130e9a1903c08a6dfa8d1bd1a343e85663ed170 Author: Paul Derscheid Date: Fri Oct 25 09:03:43 2024 +0000 Bug 38222: (QA follow-up) Show cancellation reason where applicable, appropriately handle statuses Sponsored-by: Büchereizentrale Schleswig-Holstein Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 878c78400cd3ec6dd2f3b7ae0740af49fdc0ca3a Author: Paul Derscheid Date: Fri Oct 25 07:41:07 2024 +0000 Bug 38222: (QA follow-up) DRY event listener setup for combobox resets on modal close Sponsored-by: Büchereizentrale Schleswig-Holstein Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit c297b9b10afab8504880509bda9d36d527c3adf5 Author: Martin Renvoize Date: Fri Oct 25 08:19:08 2024 +0100 Bug 38222: (QA follow-up) Add av category update Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit e03edefb296229af7fbe9fc055053fd37eb42540 Author: Paul Derscheid Date: Thu Oct 24 12:58:33 2024 +0000 Bug 38222: (follow-up) Include cancellation reason in sample notice for booking cancellation Sponsored-by: Büchereizentrale Schleswig-Holstein Signed-off-by: LEBSimonsen Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit c5d0cc271ea6e5da6a11acff3e3e97003a484015 Author: Paul Derscheid Date: Thu Oct 24 14:57:04 2024 +0000 Bug 38222: (follow-up) Only replace first numerical match in bookings count containers Sponsored-by: Büchereizentrale Schleswig-Holstein Signed-off-by: LEBSimonsen Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit c2021c3f7e0406755f4e30f3bf08270eb90584a7 Author: Paul Derscheid Date: Thu Oct 24 14:41:39 2024 +0000 Bug 38222: (follow-up) Minimally initialize combobox if passed no data via constructor or referenced elements Sponsored-by: Büchereizentrale Schleswig-Holstein Signed-off-by: LEBSimonsen Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit e3151b5570b3c33ef748f107bc485d92d6a588a4 Author: Paul Derscheid Date: Thu Oct 24 14:40:06 2024 +0000 Bug 38222: (follow-up) Remove residual inline styles from example for combobox usage Sponsored-by: Büchereizentrale Schleswig-Holstein Signed-off-by: LEBSimonsen Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 5c21ec8fe15d8179a3b4399fcc468d8d93570ad5 Author: Paul Derscheid Date: Thu Oct 24 12:18:40 2024 +0000 Bug 38222: (follow-up) Reset overflow property of modal-body to prevent clipping of combobox options instead of position: fixed Also remove the inlined styles on the unordered list. Bootstrap's dropdown handles all of this. Sponsored-by: Büchereizentrale Schleswig-Holstein Signed-off-by: LEBSimonsen Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 6a9f45686eea487e158563932bc2f4824b3db11c Author: Paul Derscheid Date: Wed Oct 23 16:44:47 2024 +0000 Bug 38222: Use comboboxes in circ/circulation.pl, bookings/list.pl, members/moremember.pl To test: 1) Apply dependencies and this patch 2) Maybe update class files w/ update_dbix_class_files.pl 3) Build a new bundle w/ yarn api:bundle 4) Restart plack 5) Add a couple bookings to a patron 6) Go to any of the above modules 7) Cancel the booking and note 7.1) That the value you input is correctly received by the backend for cancellation_reason 7.2) Do it for the other 2 modules 8) Configure some authorised values under category BOOKING_CANCELLATION 9) Repeat 7 and note that you can select them in the combobox 10) Sign off or leave your feedback Sponsored-by: Büchereizentrale Schleswig-Holstein Signed-off-by: LEBSimonsen Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 26b1a4439a8b3cabfb0f15e0377862607acd1486 Author: Paul Derscheid Date: Wed Oct 23 16:43:16 2024 +0000 Bug 38222: Add handling for cancellation reasons to cancel booking modal template, associated script Sponsored-by: Büchereizentrale Schleswig-Holstein Signed-off-by: LEBSimonsen Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 908d4f62adc255996dc425ef7798a1f10208ed0e Author: Paul Derscheid Date: Wed Oct 23 16:41:22 2024 +0000 Bug 38222: Add cancellation reason to bookings patch definition; reformat bookings definition Sponsored-by: Büchereizentrale Schleswig-Holstein Signed-off-by: LEBSimonsen Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit d5098ed6278cd5c30c8e70cd7c1a221fbecbbce0 Author: Paul Derscheid Date: Wed Oct 23 16:40:11 2024 +0000 Bug 38222: Add combobox component Sponsored-by: Büchereizentrale Schleswig-Holstein Signed-off-by: LEBSimonsen Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 5f2807b3703a29c55a0f61d653aa983b8d6123c4 Author: Kyle M Hall Date: Fri Oct 25 11:45:32 2024 +0000 Bug 36560: (QA follow-up) Tidy code Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer commit 8472279d5c91b277e1bca006887be8f9e6d4c7fa Author: David Cook Date: Tue Oct 22 02:06:18 2024 +0000 Bug 36560: Add a CSRF exception for ILS-DI API This change adds an exception for the ILS-DI API for CSRF prevention since there is no way to acquire a CSRF token for the ILS-DI API. 1. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=ILS-DI 2. Enable "ILS-DI" 3. curl -v localhost:8080/cgi-bin/koha/ilsdi.pl -d "service=AuthenticatePatron&username=REALUSER&password=REALPASSWORD" 4. Note the 403 response 5. Apply the patch 6. sudo koha-plack --restart kohadev 7. curl -v localhost:8080/cgi-bin/koha/ilsdi.pl -d "service=AuthenticatePatron&username=REALUSER&password=REALPASSWORD" 8. Note the 200 response Signed-off-by: David Nind Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer commit ef3d6a03de65a344b3dcf1cc5d2b7c6ecef60233 Author: Katrin Fischer Date: Fri Oct 25 13:41:50 2024 +0000 Bug 35906: (QA follow-up) Add AFTER to database update Signed-off-by: Katrin Fischer commit 1eb4e5c2875b0765d05bef24b7a66141d9d8d98b Author: Katrin Fischer Date: Fri Oct 25 13:25:52 2024 +0000 Bug 35906: DBIC schema update Signed-off-by: Katrin Fischer commit 0839da8fc0449e9c412b6a0b8bcfaa90b869c4e9 Author: Katrin Fischer Date: Fri Oct 25 13:21:24 2024 +0000 Bug 35906: DBRev 24.06.00.045 Signed-off-by: Katrin Fischer commit f7cc43fd2235ca277cf1cda9e67db2deeb315bf7 Author: Martin Renvoize Date: Fri Oct 18 11:40:45 2024 +0100 Bug 35906: (QA follow-up) Unit tests for effective_bookable Signed-off-by: Paul Derscheid Signed-off-by: Katrin Fischer commit 33021aa214fc9d5de447ff7b676949271a0a95b1 Author: Paul Derscheid Date: Fri Oct 18 10:33:38 2024 +0000 Bug 35906: (QA follow-up) Correct type on added bookable column Signed-off-by: Paul Derscheid Signed-off-by: Katrin Fischer commit 17706d8787e62875eada0c3e1f83a213b65bbff5 Author: Paul Derscheid Date: Fri Oct 18 10:23:30 2024 +0000 Bug 35906: (QA follow-up) Tidy block in TestBuilder.pm Signed-off-by: Paul Derscheid Signed-off-by: Katrin Fischer commit f6f28e2265207d5153a648ac6ff5a7b56392ed90 Author: Paul Derscheid Date: Fri Oct 18 09:58:19 2024 +0000 Bug 35906: (QA follow-up) Refactor (slightly) to reduce complexity in Koha/Item(s).pm, catalogue/updateitem Signed-off-by: Paul Derscheid Signed-off-by: Katrin Fischer commit 6380c89ab9c006dc18778bf8dfda259f9efdc7b5 Author: Paul Derscheid Date: Fri Oct 18 09:56:50 2024 +0000 Bug 35906: (QA follow-up) Tidy admin/itemtypes.pl, Items.t Signed-off-by: Paul Derscheid Signed-off-by: Katrin Fischer commit 50b9af836e8bbe6454115f09df3f69d529dced5e Author: Martin Renvoize Date: Fri Oct 18 09:10:00 2024 +0100 Bug 35906: (QA follow-up) Ensure we return effective_bookable The API wasn't including the effective_bookable value in responses Signed-off-by: Martin Renvoize Signed-off-by: Paul Derscheid Signed-off-by: Katrin Fischer commit 329fcc37fd2d01bc9b5d24d01879f74223eed8c7 Author: Thibaud Guillot Date: Fri Sep 27 15:04:48 2024 +0000 Bug 35906: (QA follow-up) Add bookable option for API Signed-off-by: Paul Derscheid Signed-off-by: Katrin Fischer commit d02a717ab6d7b1f866b97139409ae0ffa62db2a8 Author: Martin Renvoize Date: Mon Feb 26 19:28:03 2024 +0000 Bug 35906: (QA follow-up) Fix item-type schema Signed-off-by: Esther Signed-off-by: Paul Derscheid Signed-off-by: Katrin Fischer commit db6cce8852736802822534eba5c310dc5a841084 Author: Martin Renvoize Date: Mon Feb 26 16:14:28 2024 +0000 Bug 35906: Remove preference and add override handling This patch updates the bookable nature of items to allow setting at the itemtype level and then overriding that setting at item level should you so wish to do so. We also now properly handle the item_level-itypes preference such that we look at item or biblioitem level appropriately. Signed-off-by: Esther Signed-off-by: Paul Derscheid Signed-off-by: Katrin Fischer commit 8dde2730a564f4b248f6cec6d40693e1fe1ad15c Author: Thibaud Guillot Date: Fri Feb 23 10:00:01 2024 +0100 Bug 35906: Add unit test Signed-off-by: Esther Signed-off-by: Martin Renvoize Signed-off-by: Paul Derscheid Signed-off-by: Katrin Fischer commit 39891095a63b43ad0cfa74acb192e186c8b68706 Author: Thibaud Guillot Date: Thu Jan 25 14:14:07 2024 +0100 Bug 35906: Add bookable option on itemtype Actually new "booking" feature can be set on an item but no directly on an itemtype. This patch adds this possibility. Test plan: 1) Test this new feature on an item as it were currently working. 2) Apply this patch 3) Run updatedatabase.pl 4) Reload Schema by running update_dbix_class_files.pl 5) Change new syspref 'item-level_booking' to 'itemtype' 6) Edit an itemtype, there is a new checkbox to add 'bookable' option 7) Test it with item with this itemtype, if there is 1 item at least you will see 'Booking' tab. 8) You can change syspref to 'item' to see the current behavior Note: When item-level_booking is set on 'itemtype' you can change dropdown option to 'No' on item bookable option. Sponsored by: Association de Gestion des Œuvres Sociales d'Inria (AGOS) Signed-off-by: Esther Signed-off-by: Martin Renvoize Signed-off-by: Paul Derscheid Signed-off-by: Katrin Fischer commit 94210ae47111210739daf12d801d8b5b472b0932 Author: Martin Renvoize Date: Fri Oct 25 12:04:24 2024 +0100 Bug 38175: (QA follow-up) Add cancelled handling to find_booking We need to also exclude cancelled bookings from the find_booking routine used at checkout. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer